Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 3 |Implement shell tools #241

sheida-shab · 2025-11-20T21:28:16Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

LonMcGregor

Good work on these tasks, apologies for the lateness in review

You have taken a good approach at manually parsing the arguments. You might consider investigating if there are any libraries or APIs you could use to help you with this. In a more complex shell tool, it might be difficult to manually check arguments this way. It would also make it easier to combine arguments, e.g.allowing wc -w -l instead of only one at a time

LonMcGregor · 2025-12-17T16:31:12Z

implement-shell-tools/cat/cat.js

+                lineNumber ++ ;
+                }
+            }
+            }


The formatting is a bit unclear here, do you know of any tools in the command line or the IDE that could help to improve this?

I’m using VS Code with Prettier enabled, but I’m not sure why the file wasn’t properly formatted when saved. I manually reformatted it afterwards.

LonMcGregor · 2025-12-17T16:32:40Z

implement-shell-tools/cat/cat.js

+       const filesNameArray = await glob(fileNamePattern);
+       filesNameArray.sort();
+       let lineNumber = 1;
+       //console.log(filesNameArray);


Tip: Avoid committing commented old code

I Fixed it.

LonMcGregor · 2025-12-17T16:34:41Z

implement-shell-tools/cat/cat.js

@@ -0,0 +1,46 @@
+import { promises as fs } from "node:fs";
+import { glob } from "glob";


When I run this code I get an error Cannot find package 'glob'. Do you see this also?

Thanks for your comment but I don't see any error !

LonMcGregor · 2025-12-17T16:35:26Z

implement-shell-tools/ls/ls.js

+import { promises as fs } from "node:fs";
+async function listDir() {
+   let finalFileList;
+   const flag = process.argv[2];


The readme also asks you to try implementing the -1 option, can you try this?

When I initially implemented the code, the -1 flag behavior was applied automatically by default, so I didn’t explicitly implement it. However, based on your feedback, I have now updated the implementation to handle the -1 flag explicitly.

LonMcGregor · 2025-12-17T16:37:07Z

implement-shell-tools/wc/wc.js

+
+    for(const file of commandLineArray){
+        const fileContent=await fs.readFile(file , 'utf-8');
+        const fileBuffer=await fs.readFile(file);


Do you need to read the file in two times? What impact will this have on performance?

You're right — the file is being read twice unnecessarily, which affects performance. This could be improved by reading the file once and reusing the buffer. I updated the code.

LonMcGregor · 2025-12-17T16:38:51Z

implement-shell-tools/wc/wc.js

+    if(commandLineArray.length>1){
+        switch (flags[0]) {
+          case "-l":
+            console.log(`${String(totalLines).padStart(4)} total`);


There is some duplicated code here, can you reduce that?

I fixed it by implementing a function.

LonMcGregor · 2025-12-22T12:26:18Z

Good work on this.
I think there was an issue in your "add support for -1 flag" - this seems to have comitted a lot of extra files. There's now 300+ listed in the changeset for this PR. Can you take another look at that?

sheida-shab · 2025-12-24T15:13:25Z

Thanks for your feedback.I think I fixed the issue.
Could you please review it again ?

LonMcGregor · 2026-01-05T09:44:19Z

This looks good, good work

sheida-shab added 12 commits November 18, 2025 23:21

implement basic cat command

0ac00bc

implementing wild cards pattern

b640def

fixing the sort bug

cb08903

implementing flag -n

dfc9d45

implementing -b flag

4aceacf

implementing ls -1

eaf62b9

implement ls -1 path

e85e714

Filtering hidden files name

f0dde4b

implementing -a flag

de2cbfb

implementing basic wc

99dfd5d

implementing first wc statement

604ccb5

fixing presenting problems

303b96f

sheida-shab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Tools The name of the module. labels Nov 20, 2025

LonMcGregor reviewed Dec 17, 2025

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 17, 2025

sheida-shab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 18, 2025

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 22, 2025

sheida-shab added 4 commits December 22, 2025 17:25

implementing flags -l , -c , -w

2a2f3df

Update .gitignore and cat.js

0597cbd

Add support for -1 flag to control output format

aa561c7

fixed wc repeated file read and duplicate code

5b9cc2d

sheida-shab force-pushed the implement-shell-tools branch from 9138dac to 5b9cc2d Compare December 22, 2025 18:07

Remove virtual environment and node_modules from repo

163f71f

sheida-shab removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Dec 24, 2025

sheida-shab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 24, 2025

LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 5, 2026

		@@ -0,0 +1,46 @@
		import { promises as fs } from "node:fs";
		import { glob } from "glob";

Uh oh!

Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 3 |Implement shell tools #241

Are you sure you want to change the base?

Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 3 |Implement shell tools #241

Uh oh!

Conversation

sheida-shab commented Nov 20, 2025

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonMcGregor commented Dec 22, 2025

Uh oh!

sheida-shab commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LonMcGregor commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sheida-shab commented Dec 24, 2025 •

edited

Loading