London | 25-SDC-July | Priscilla Emebo | Sprint 4 | Python Implementation #162
Conversation
Priscilla-EM
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Remember to update the default PR text when submitting on github.
Good work on these tasks, I only have comments for one of your files
There was a problem hiding this comment.
There is some duplication of code in this file. Can you spot where it is and find a way to reduce this?
LonMcGregor
added
Reviewed
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
6 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Thank you! I have removed the duplicated code |
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
This is an improvement, good work. always be on the lookout for ways you can abstract and pullout code into separate functions like this.
LonMcGregor
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
Implementation of custom wc command in Python to mirror the behavior of the real Unix wc command.
This PR implements a Python version of the Unix wc (word count) command.
The script supports counting:
Lines with the -l flag
Words with the -w flag
Bytes with the -c flag
It also supports multiple files and displays a total line when more than one file is provided.
I verified the script works correctly for the following commands as required in the README:
wc sample-files/*
wc -l sample-files/3.txt
wc -w sample-files/3.txt
wc -c sample-files/3.txt
wc -l sample-files/*