generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 42
London | 25-SDC-July | Franklin Kamela | Sprint 4 | Feature/implement cowsay #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fradoka
wants to merge
11
commits into
CodeYourFuture:main
Choose a base branch
from
Fradoka:feature/implement-cowsay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0611383
exercise ls
Fradoka 1f5b567
exercise cat
Fradoka 0a71087
exercise wc
Fradoka 72271cf
exercise grep
Fradoka 0d3bc17
exercise sed
Fradoka 22a04bb
exercise awk
Fradoka 32a3a87
exercise number systems
Fradoka 4ef88e2
Revert mistaken commits from main branch
Fradoka 0d554e0
working on cowsay
Fradoka 28a3a0a
completed cowsay
Fradoka 12ed746
amended code to address review
Fradoka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import argparse | ||
| import cowsay | ||
| import sys | ||
|
|
||
| available_animals = cowsay.char_names | ||
|
|
||
| parser = argparse.ArgumentParser( | ||
| prog="cowsay", | ||
| description="Uses the cowsay library to show user-supplied text, as said by a specified animal", | ||
| ) | ||
|
|
||
| parser.add_argument("--animal", help="The animal to be saying things", default="cow", choices=available_animals) | ||
| parser.add_argument("message", help="The message to say", nargs="*", default=["Hello, World!"]) | ||
|
|
||
| args = parser.parse_args() | ||
|
|
||
| msg = " ".join(args.message) | ||
| animal = args.animal.lower() | ||
|
|
||
| if not hasattr(cowsay, animal): | ||
| print(f"Invalid choice: '{args.animal}' (choose from: {', '.join(available_animals)})") | ||
| sys.exit(1) | ||
|
|
||
| # Dynamically call the cowsay function for the chosen animal | ||
| getattr(cowsay, animal)(msg) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you have specified the choices argument in, do you need to include this here as well? If you un with an invalid animal, you'll see some duplication of errors in the output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LonMcGregor, i did see that but the example test case in README file
% python3 cow.py --animal fish Turtles are cool too!showed the message as such. should i still edit this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot the readme explicitly requested that. In that case, this implementation is good and complete. Well done.