Skip to content

London | 25-SDC-July | Eyuel Abraham | Sprint 4 | Implementing cowsay #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eyuell21 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Eyuel Abraham | Sprint 4 | Implementing cowsay #157

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5af07ad
Added gitignore files.
eyuell21 Aug 2, 2025
e448fe5
created a requirements.txt files including the libraries to be instal…
eyuell21 Aug 2, 2025
96c0d12
Cowsay python implementation
eyuell21 Aug 5, 2025
687e4d8
Fix printing 'None' when cowsay animal functions print directly inste…
eyuell21 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion implement-cowsay/cow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def main():
try:
animal_func = getattr(cowsay, args.animal)
Copy link

@DaryaShirokova DaryaShirokova Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check out an alternative get_output_string method here to avoid getattr (not the best choice to use if there is alternative - it make code more readable).

Copy link
Author

@eyuell21 eyuell21 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, Thank you 🙏

output = animal_func(message)
print(output)
if output is not None:
Copy link

@DaryaShirokova DaryaShirokova Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So can you explain in which cases the output is None here and when it is not None?

Copy link
Author

@eyuell21 eyuell21 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output is None only if the animal function doesn't return anything. In the official cowsay module, it always returns a string.

The output is not None in normal cases because standard cowsay animal functions return a string of ASCII art.

Copy link

@DaryaShirokova DaryaShirokova Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it print None when you remove if output is not None:? What is considered to be not a normal case?

print(output)
except AttributeError:
print(f"Error: '{args.animal}' is not a valid animal.", file=sys.stderr)
sys.exit(1)
Expand Down