Skip to content

Glasgow | 25-SDC-July | Prati Amalden | Sprint 3 | Implement shell tools #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PratiAmalden wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Glasgow | 25-SDC-July | Prati Amalden | Sprint 3 | Implement shell tools #130

PratiAmalden wants to merge 8 commits into from

Conversation

@PratiAmalden
Copy link

@PratiAmalden PratiAmalden commented Jul 29, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@PratiAmalden PratiAmalden added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2025
@PratiAmalden PratiAmalden linked an issue Jul 29, 2025 that may be closed by this pull request
01 Implement shell tools (cat, ls, wc) in JavaScript with NodeJS PratiAmalden/My-Coursework-Planner#123
Open
@illicitonion illicitonion added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 12, 2025
illicitonion
illicitonion reviewed Aug 12, 2025
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is generally looking really good. I left a few comments about specific things.

Also, in your PR description, you didn't fill in the template of what the changelist does, or what questions you had - please either fill in or remove the tempalte sections.

@illicitonion illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 12, 2025
@illicitonion illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 28, 2025
@illicitonion
Copy link
Member

illicitonion commented Aug 28, 2025

Looks good! Thanks!

@github-actions
Copy link

github-actions bot commented Aug 28, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 28, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

Nataliia74 added a commit to Nataliia74/Module-Tools that referenced this pull request Nov 5, 2025
@Nataliia74
01 Number systems exercises CodeYourFuture#130
f3fa127
@Nataliia74 Nataliia74 mentioned this pull request Nov 5, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonion illicitonion illicitonion left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

01 Implement shell tools (cat, ls, wc) in JavaScript with NodeJS

2 participants

@PratiAmalden @illicitonion