Skip to content

London | 26-ITP-January | Laura C | Sprint 2 | Form Controls#996

Closed
lauracs24 wants to merge 9 commits intoCodeYourFuture:mainfrom
lauracs24:form-controls
Closed

London | 26-ITP-January | Laura C | Sprint 2 | Form Controls#996
lauracs24 wants to merge 9 commits intoCodeYourFuture:mainfrom
lauracs24:form-controls

Conversation

@lauracs24
Copy link
Copy Markdown

@lauracs24 lauracs24 commented Jan 20, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Built an HTML-only form to collect customer name, email, colour, and size
  • Added required validation using HTML attributes
  • Grouped radio inputs using fieldset and legend
  • Tested form validation in the browser

Questions

No questions at the moment; happy to receive feedback.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 20, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 081e848
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6974f4d065b5010008015635
😎 Deploy Preview https://deploy-preview-996--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 20, 2026
@lauracs24 lauracs24 changed the title London | 26-ITP-January | Laura C | Sprint 1 | Form Controls London | 26-ITP-January | Laura C | Sprint 2 | Form Controls Jan 20, 2026
@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 20, 2026
@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 24, 2026
A-O-Emmanuel
A-O-Emmanuel reviewed Jan 24, 2026
View reviewed changes
Copy link
Copy Markdown

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good attempt, but can you come up with a better way to check what a valid name is ,apart from using the html required and minlength attributes

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 24, 2026
@lauracs24
Copy link
Copy Markdown
Author

lauracs24 commented Jan 24, 2026

@A-O-Emmanuel - Just added pattern and title, hope it helps.

@lauracs24 lauracs24 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module labels Jan 24, 2026
@lauracs24
Copy link
Copy Markdown
Author

lauracs24 commented Jan 29, 2026

Hi @A-O-Emmanuel, let me know if you need anything else

@lauracs24
Copy link
Copy Markdown
Author

lauracs24 commented Jan 30, 2026

@cjyuan
@MorganDavid

Please let me know if any of you can review this request, as I would like to submit my module 1 onboarding on time, deadline is in a week. Thank you!

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jan 30, 2026

@lauracs24 It seems you have addressed @A-O-Emmanuel 's request.
I will go ahead and add a "Complete" label to this PR on his behalf.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 30, 2026
@A-O-Emmanuel
Copy link
Copy Markdown

A-O-Emmanuel commented Jan 30, 2026

Sorry for the late reply @lauracs24 , thank you @cjyuan

@lauracs24 lauracs24 mentioned this pull request Jan 31, 2026
Open
@lauracs24 lauracs24 moved this to Awaiting Approval🚀 in Coursework Planner Feb 21, 2026
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@A-O-Emmanuel A-O-Emmanuel A-O-Emmanuel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lauracs24 @cjyuan @A-O-Emmanuel @illicitonion