-
-
Notifications
You must be signed in to change notification settings - Fork 500
London | 26-ITP-May | Mandip Sanger | Sprint 2 | Wireframe #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mandipsanger
wants to merge
13
commits into
CodeYourFuture:main
Choose a base branch
from
mandipsanger:Wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81
−10
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cd266a2
update links
mandipsanger 761fd79
add link for articles
mandipsanger 254364a
add style sheet
mandipsanger 3dfe293
closing tags
mandipsanger 948e4de
commit errors
mandipsanger af35abe
image width and height
mandipsanger 403cf49
fix errors
mandipsanger be4c074
fix errors
mandipsanger b8adb1c
fix revert form control original html
mandipsanger 5b0ba5a
fix read me error
mandipsanger 3cd9c74
fix header error
mandipsanger ef92e54
fix html errors
mandipsanger 4ce5321
fix footer
mandipsanger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better practice is to set the image dimension in CSS.
Providing meaningful
alttext is important because it ensures images are accessible to people using screen readers and also helps when imagesfail to load, giving users essential context about the content or function of the image.
Can you give a more descriptive
altvalue to all images?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much I think I have solved all the issues.