London | 26-ITP-May | Raihan Sharif | Sprint 1 | Form Control#1218
Closed
RaihanSharif wants to merge 7 commits intoCodeYourFuture:mainfrom
Closed
London | 26-ITP-May | Raihan Sharif | Sprint 1 | Form Control#1218RaihanSharif wants to merge 7 commits intoCodeYourFuture:mainfrom
RaihanSharif wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
Select element now does not select one of the values by default. Also chose not to remove trailing / in void elements. As prettier does not allow this. Would require installing and configuring an unmaintained extension.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
Author
|
Will resubmit with correct file changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Form with name input and email input with necessary validation. Inputs for color and size with pre-defined options. Validated with lighthouse for accessibility.