Sheffield | 26-ITP-May | CJ Yuan | Sprint 1 | Form Controls#1217
Closed
cjyuan wants to merge 3 commits intoCodeYourFuture:mainfrom
Closed
Sheffield | 26-ITP-May | CJ Yuan | Sprint 1 | Form Controls#1217cjyuan wants to merge 3 commits intoCodeYourFuture:mainfrom
cjyuan wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
cjyuan
added
Needs Review
Added form fields for personal and product information including name, email, t-shirt colour, and size.
cjyuan
commented
May 5, 2026
Contributor
Author
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
I'm seeing different Lighthouse accessibility scores: 100 on Netlify and 92 in Chrome. Should I be concerned about the lower Chrome score?
Please rely on Chrome's Lighthouse score, as it more accurately reflects the browser experience. Can you improve the score to 100?
Comment on lines
+40
to
+46
| <label>T-Shirt Size:</label> | ||
| <label>XS<input type="radio" name="size" value="extra-small" required></label> | ||
| <label>S<input type="radio" name="size" value="small"></label> | ||
| <label>M<input type="radio" name="size" value="medium"></label> | ||
| <label>L<input type="radio" name="size" value="large"></label> | ||
| <label>XL<input type="radio" name="size" value="extra-large"></label> | ||
| <label>XXL<input type="radio" name="size" value="double-extra-large"></label> |
Contributor
Author
There was a problem hiding this comment.
Why not implement a drop-down list?
cjyuan
added
Reviewed
cjyuan
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Questions
I'm seeing different Lighthouse accessibility scores: 100 on Netlify and 92 in Chrome. Should I be concerned about the lower Chrome score?