Glasgow | ITP January-2026| Tuan Nguyen | Sprint 1| Form control by Jacknguyen4438 · Pull Request #1103 · CodeYourFuture/Module-Onboarding

Jacknguyen4438 · 2026-01-31T13:04:39Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have added input allow for the user submit their data through the form website.

Questions

No question

…ibility.

netlify · 2026-01-31T13:05:24Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`ba8b66c`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/698e5219a191ce00085b9bac
😎 Deploy Preview	https://deploy-preview-1103--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

jenny-alexander

Nice work @Jacknguyen4438. I left a comments for you to review.

jenny-alexander · 2026-02-06T04:38:16Z

    <footer>
      <!-- change to your name-->
-      <h2>By HOMEWORK SOLUTION</h2>
+      <h2>By Tuan Nguyen</h2>


I suggest using something other than <h2> in the footer. By using <h2> you are announcing a major section header within your footer.

Thank you for the comment, I will find some other tag that are correct.

jenny-alexander · 2026-02-06T04:45:55Z

+        <br>
+        <div>
+        <label for="Color">T-shirt color:</label>
+        <input type="color" id="Color" name=" Product color" required>


Wow 🤩, I really like this unique choice you made with the color picker. Very interesting.

Thank you, I choose this because I I think is easier and provide the user choice more precise.

jenny-alexander · 2026-02-06T04:51:00Z

@@ -17,11 +17,41 @@ <h1>Product Pick</h1>
        <!-- 


I think these comments can be removed since their intention was to help you complete the exercise. Comments in the code can be useful for:

Describing complex logic or workarounds

Explaining "why," not "what"

TODO notes for incomplete work

jenny-alexander · 2026-02-06T04:52:14Z

Can you review the exercise requirements? Should there be changes in the README file?

I have check the criteria and make some change. I am happy report that the change now fit with the course check list.

jenny-alexander · 2026-02-06T04:55:53Z

+        <br>
+        <div>
+        <label for="Color">T-shirt color:</label>
+        <input type="color" id="Color" name=" Product color" required>


I see a leading space in the name=" Product color". This could cause issues if the form was ever submitted for processing.

Thank you for point this out, this is some gramma mistake I have fix this and it shouldn't be a problem.

jenny-alexander · 2026-02-06T04:56:19Z

+        </div>
+        <div>
+        <br>
+        <label for="Size">Shirt size


I see something missing on line 36. Can you find the problem?

Yes I have check and see that is should be after size word and not nested the whole select element.

…rror and update the code for better reading

…/Module-Onboarding-Wireframe-to-Web-Code-2026 into Form-control-work

…r practice.

jenny-alexander

@Jacknguyen4438 Nice work making those code corrections.

Can you review the<label> attributes? Specifically check the casing of your for attributes. It's best practice to user lowercase (even though uppercase is technically ok).
https://courses.cs.washington.edu/courses/cse154/codequalityguide/html/#lowercase-elements

Jacknguyen4438 · 2026-02-12T22:23:11Z

@jenny-alexander Hello, thank you for your time on reviewing on my course work. I am very surprise that I received your review at
02:46 AM in the morning. I have read your recent comment and I change all the attribute value to low case for better practice

jenny-alexander · 2026-02-13T03:15:34Z

@jenny-alexander Hello, thank you for your time on reviewing on my course work. I am very surprise that I received your review at 02:46 AM in the morning. I have read your recent comment and I change all the attribute value to low case for better practice

@Jacknguyen4438 I live in the United States so it was probably only 8:46pm here 😁. Your PR looks good now.

Jacknguyen4438 and others added 5 commits January 31, 2026 02:22

Creating and adding input for the user

e8bbf03

Doing required check on task need to be done

6ab6dd5

Nesting select and option inside the parent label to help with access…

2b6606d

…ibility.

Doing some attribute to some input and adding check to learning object

ee353eb

Merge branch 'CodeYourFuture:main' into Form-control-work

e6ac02a

Jacknguyen4438 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 31, 2026

Jacknguyen4438 mentioned this pull request Jan 31, 2026

ITP January-2026/ Onboarding/ Tuan Ngoc Nguyen Jacknguyen4438/My-Coursework-Planner#9

Open

jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 5, 2026

jenny-alexander self-requested a review February 5, 2026 13:44

jenny-alexander reviewed Feb 6, 2026

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 6, 2026

This was referenced Feb 7, 2026

Get Code Review and Iterate Jacknguyen4438/My-Coursework-Planner#29

Closed

Get Code Review and Iterate Jacknguyen4438/My-Coursework-Planner#35

Closed

Get Code Review and Iterate Jacknguyen4438/My-Coursework-Planner#19

Closed

Jacknguyen4438 added 6 commits February 12, 2026 00:49

Making some improvement after reading some review comment. Fix some e…

5e42f93

…rror and update the code for better reading

Merge branch 'Form-control-work' of https://github.com/Jacknguyen4438…

7b5e8cc

…/Module-Onboarding-Wireframe-to-Web-Code-2026 into Form-control-work

Remove comment for easier reading, changing the footer tags for bette…

8d1277c

…r practice.

fixing some grammar error and change fit with the course work criteria

205ba3b

Small change to the radio button

9c5a249

adding require attribute to radio input

7ec34c7

Jacknguyen4438 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 12, 2026

jenny-alexander reviewed Feb 12, 2026

View reviewed changes

jenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 12, 2026

Jacknguyen4438 added 3 commits February 12, 2026 22:14

Make some change to for attribute and it value lower case.

978ad11

Make some change for the rest of all attribute value.

9d9847f

minor change some id and label link

ba8b66c

Jacknguyen4438 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 12, 2026

Jacknguyen4438 mentioned this pull request Feb 14, 2026

Form Controls Jacknguyen4438/My-Coursework-Planner#21

Closed

3 tasks

Jacknguyen4438 closed this May 3, 2026

This was referenced May 10, 2026

ITP May-2026/ Onboarding / Tuan Ngoc Nguyen Jacknguyen4438/My-Coursework-Planner#109

Open

Glasgow | ITP-MAY-2026 | Tuan Nguyen | Sprint 1 | Form control #1214

Open

Jacknguyen4438 added 📅 Sprint 1 Assigned during Sprint 1 of this module and removed 📅 Sprint 2 Assigned during Sprint 2 of this module labels May 11, 2026

Uh oh!

Conversation

Jacknguyen4438 commented Jan 31, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

netlify Bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

Jacknguyen4438 commented Feb 12, 2026

Uh oh!

jenny-alexander commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Jan 31, 2026 •

edited

Loading