Sheffield | 26-Jan-ITP | Karim Mhamdi | Sprint 2 | Form Controls#1102
Sheffield | 26-Jan-ITP | Karim Mhamdi | Sprint 2 | Form Controls#1102KKtech06 wants to merge 16 commits into
Conversation
…ccessibility improvements
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
KKtech06
added
the
Needs Review
There was a problem hiding this comment.
-
Branch is not clean -- a branch for the Form Controls exercise should not contain changed files in the Wireframe folder. Can you revert the changes made in the Wireframe folder?
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
I spotted some minor inconsistent use of letter case and wordings on the form. May I suggest sharing your code to an AI tool and ask it to review your code in terms of semantic, accessibility, typo, and consistency?
It can often help us catch errors, improve consistency, and reinforce best practices. -
It is uncommon to have a submit button in the middle of the form. Can you move it to the bottom of the form?
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| <form> | ||
| <table> |
There was a problem hiding this comment.
I don't think it is a good practice to use table to layout form elements.
For this exercise, just use <div> or <br> to create enough space to pass the Lighthouse accessibility check.
| <td><input | ||
| type="text" | ||
| id="name" | ||
| name="name" | ||
| minlength="2" | ||
| required ></td> |
There was a problem hiding this comment.
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?
cjyuan
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
KKtech06
force-pushed
the
feature/form-controls
branch
from
5a3d451 to
239d82b
Compare
KKtech06
added
Needs Review
|
Changes look good. Well done. |
cjyuan
added
Complete
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
3 participants
Learners, PR Template
Self checklist
Changelist:
I created a form control with inputs where you can write your info such as your name and email and have also used labels to created section of colours to pick and sizes. and have ran a inspection test with lighthouse and got a score of 100
Questions
N/A