Skip to content

Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 2 | Form Controls #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pretty548 wants to merge 6 commits into from
Closed

Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 2 | Form Controls #1097

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba219ab
added html for the form
Pretty548 May 28, 2025
c383fc7
Merge branch 'CodeYourFuture:main' into feature/form-control
Pretty548 Jun 3, 2025
2008fe3
added my second initial
Luke-Manyamazi Jan 30, 2026
caa60b3
wrapped radio buttons inside label elements
Pretty548 Feb 2, 2026
30cc3f5
Merge branch 'feature/form-control' of https://github.com/Pretty548/M…
Pretty548 Feb 2, 2026
1bab41c
checked for consistency and possible improvements
Pretty548 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 55 additions & 6 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,64 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<label for="customer-name">Customer Name:</label><br />
<input
type="text"
id="customer-name"
name="customer-name"
minlength="2"
required
><br><br>
<label for="customer-email">Email:</label><br>
<input
type="email"
id="customer-email"
name="customer-email"
required
/><br><br>
<fieldset>
<legend>Choose a T-shirt Colour:</legend>
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wordings used on lines 32 and 58 could be made more consistent.

May I suggest showing your code to an AI tool and ask it to check for consistency and possible improvements?
It can often help us catch errors, improve consistency, and reinforce best practices.

Copy link
Copy Markdown
Author

@Pretty548 Pretty548 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for pointing out that. i have checked and improved , i hope now its better.

<input
type="radio"
id="color-red"
name="color"
value="red"
required
/>
<label for="color-red">Red</label>

<input
type="radio"
id="color-blue"
name="color"
value="blue"
/>
<label for="color-blue">Blue</label>
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
We can also wrap the radio button inside the label element as:

<label><input type="radio" name="color" value="blue"> Blue</label>

This way, we don't have to introduce id and for attributes.

Copy link
Copy Markdown
Author

@Pretty548 Pretty548 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Cjyuan for your suggestion. I have wrapped the radio buttons as per your suggestion and i hope i did it right


<input
type="radio"
id="color-green"
name="color"
value="green"
/>
<label for="color-green">Green</label>
</fieldset><br>
<label for="size">Select Size:</label>
<select id="size" name="size" required>
<option value="">--Select Size--</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>

<button type="submit">Submit</button>
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<p>Pretty N Taruvinga</p>
</footer>
</body>
</html>
Loading