Skip to content

Sheffield | 26-Jan-ITP | Mona-Elatntawy | Sprint 2 | Form-control#1089

Closed
Mona-Eltantawy wants to merge 6 commits intoCodeYourFuture:mainfrom
Mona-Eltantawy:Form-control-m
Closed

Sheffield | 26-Jan-ITP | Mona-Elatntawy | Sprint 2 | Form-control#1089
Mona-Eltantawy wants to merge 6 commits intoCodeYourFuture:mainfrom
Mona-Eltantawy:Form-control-m

Conversation

@Mona-Eltantawy
Copy link
Copy Markdown

@Mona-Eltantawy Mona-Eltantawy commented Jan 28, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • I created a form with a semantic html.
  • I added inputs and associated labels.
  • I require a valid name and have defined a valid name as a text string of two characters or more.
  • I require a valid email.
  • I require one colour from a defined set of 3 colours.
  • I require one size from a defined set of 6 sizes.
  • checked the Lighthouse Accessibility and get 100 score.

@Mona-Eltantawy
Added:
45fc25d 
- Inputs for customer name and email.
 -Associated lables.
 - Rquried a valid name and email.
@Mona-Eltantawy
Added new fieldset for product details, included:
96549ee 
- size
-colour
-quantity
@Mona-Eltantawy
Edited typo symatics.
1b069eb
@Mona-Eltantawy
Added more spaces using html<br> & <hr> attributes
50b3131
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 28, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 956f126
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698a64b6fb70fc0008b9e455
😎 Deploy Preview https://deploy-preview-1089--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Mona-Eltantawy Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Mona-Eltantawy Mona-Eltantawy changed the title Sheffield l 26-Jan-ITP l Mona-Eltantawy l Sprint 2 l My form exercise Sheffield | 26-Jan-ITP | Mona-Elatntawy | Sprint 2 | My form exercise Jan 28, 2026
@Mona-Eltantawy Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 28, 2026
@Mona-Eltantawy Mona-Eltantawy changed the title Sheffield | 26-Jan-ITP | Mona-Elatntawy | Sprint 2 | My form exercise Sheffield | 26-Jan-ITP | Mona-Elatntawy | Sprint 2 | Form-control Jan 28, 2026
@Mona-Eltantawy Mona-Eltantawy added 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. labels Jan 28, 2026
cjyuan
cjyuan reviewed Jan 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://validator.w3.org/, there are errors in your code. Can you fix them?

Comment thread Form-Controls/index.html Outdated
Comment on lines +28 to +33
<div>
<label for="password">Password</label><br>
<input id="password" name="password" type="password" placeholder="At least 8 characters" minlength="8"
autocomplete="current-password" required size="30">
</div><br>

Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good that you are trying different input elements. It is just unusual to have a password field in a T-shirt ordering form.

Copy link
Copy Markdown
Author

@Mona-Eltantawy Mona-Eltantawy Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you CJ. I deleted the 'password' input.
can you please re-review it.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 29, 2026
@Mona-Eltantawy Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jan 31, 2026

You missed this comment, :)

According to https://validator.w3.org/, there are errors in your code. Can you fix them?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@Mona-Eltantawy Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026
@Mona-Eltantawy
Copy link
Copy Markdown
Author

Mona-Eltantawy commented Feb 9, 2026

You missed this comment, :)

According to https://validator.w3.org/, there are errors in your code. Can you fix them?

I sorted this

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Feb 9, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 9, 2026
@Mona-Eltantawy
Copy link
Copy Markdown
Author

Mona-Eltantawy commented Feb 10, 2026

Changes look good. Well done.

Thank you CJ

@Mona-Eltantawy Mona-Eltantawy mentioned this pull request Feb 10, 2026
Open
4 tasks
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mona-Eltantawy @cjyuan @illicitonion