Skip to content

BIRMINGHAM | 26-ITP-JAN | MERVE REIS | Sprint 2 | PRODUCT FORM #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mervereis wants to merge 4 commits into from
Closed

BIRMINGHAM | 26-ITP-JAN | MERVE REIS | Sprint 2 | PRODUCT FORM #1079

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3680011
form created
mervereis Jan 26, 2026
fb2631b
product form updated
mervereis Jan 30, 2026
05ca173
minlength added
mervereis Feb 2, 2026
ff11cec
reverted unnecessary arias
mervereis Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 59 additions & 25 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,61 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>
</html>

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Product Form</title>
<link rel="stylesheet" href="style.css" />
Copy link
Copy Markdown

@takanocap takanocap Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done for the good Job. You have also included accessibility thats very good. Please keep it up. However, your styles.css may be missing or using the wrong reference. Please check this

Copy link
Copy Markdown
Author

@mervereis mervereis Feb 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takanocap I removed unused style linking.

</head>

<body>
<header>
<h1>Product Pick</h1>
</header>

<main>
<form aria-label="Product selection form">
<div>
<label for="name">Name</label>
<input minlength="2" placeholder="name surname" id="name" type="text" name="Name" required
aria-required="true" />
</div>

<div>
<label for="email">E-mail</label>
<input type="email" name="E-mail" id="email" placeholder="[email protected]" required aria-required="true" />
Copy link
Copy Markdown

@takanocap takanocap Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to use the minlength for additional validation for email?

Copy link
Copy Markdown
Author

@mervereis mervereis Feb 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takanocap I added min length feature.

</div>

<div>
<label for="colour">Colour</label>
<select name="colour" id="colour" required aria-required="true" aria-label="Select a colour">
Copy link
Copy Markdown

@takanocap takanocap Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welldone for the good job.
when we have a visible label could there be a reason why using aria-label will be redundant ? what is the difference between the aria-label and aria-labelledby, when should we use one or the other
would there be a reason why using aria-required and required may be redundant ?

Copy link
Copy Markdown
Author

@mervereis mervereis Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takanocap Thanks for the feedback. Since there is already a visible label and the required attribute provides the necessary accessibility information, I’ve reverted the redundant aria-label and aria-required usage.

<option value="">Select a colour</option>
<option value="Green">Green</option>
<option value="Yellow">Yellow</option>
<option value="Purple">Purple</option>
</select>
</div>

<div>
<label for="size">Size</label>
<select name="size" id="size" required aria-required="true" aria-label="Select a size">
<option value="">Select a size</option>
<option value="xs">Xs</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</div>

<button type="submit">Submit</button>
</form>
</main>

<footer>
<h2>Merve Reis</h2>
</footer>
</body>

</html>