-
-
Notifications
You must be signed in to change notification settings - Fork 451
BIRMINGHAM | 26-ITP-JAN | MERVE REIS | Sprint 2 | PRODUCT FORM #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,57 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
| <p> | ||
| A basic blueprint for webpage | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>What is the purpose of readme files?</h2> | ||
| <p> | ||
| A README file usually serves as the primary, high-level documentation for a | ||
| software project, dataset, or repository, | ||
| designed to help users and developers understand, install, and use the project | ||
| </p> | ||
| <a href="https://www.makeareadme.com">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="wireframe.png" alt="wireframe pictures" /> | ||
| <h2>What's the purpose of wireframe?</h2> | ||
| <p>The purpose of a wireframe is to serve as a blueprint for a digital product (website, app) by focusing on its | ||
| structure, | ||
| layout, and functionality, not visual design (colors, fonts). | ||
| </p> | ||
| <a href="https://www.figma.com/resource-library/what-is-wireframing/">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="/code-review-flow.png" alt="whats branch" /> | ||
| <h2>What's the branch in git?</h2> | ||
| <p>A branch in Git is simply a lightweight movable pointer to one of these commits. The default branch name in Git | ||
| is master . As you start making commits, you're given a master branch that points to the last commit you made. | ||
| </p> | ||
| <a | ||
| href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches">Read | ||
| more</a> | ||
| </article> | ||
|
|
||
| </main> | ||
| <footer style="border-top: 1px solid; padding: 2rem;"> | ||
| If you want to learn more about <a href="https://www.productplan.com/glossary/wireframe/">Wireframe</a> | ||
|
|
||
|
|
||
| </footer> | ||
| </body> | ||
|
|
||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done for the good Job. You have also included accessibility thats very good. Please keep it up. However, your styles.css may be missing or using the wrong reference. Please check this
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takanocap I removed unused style linking.