Glasgow | ITP-Jan-2026 | Alasdair MacDonald | Sprint 2 | Form Control by MacDonald91 · Pull Request #1073 · CodeYourFuture/Module-Onboarding

MacDonald91 · 2026-01-26T12:23:53Z

Self-checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed all the tasks, no errors.

netlify · 2026-01-26T12:24:01Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`edd78f3`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/699724955955dd00084b5f13
😎 Deploy Preview	https://deploy-preview-1073--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 96 (🔴 down 4 from production) SEO: 87 (🟢 up 1 from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

A-O-Emmanuel

You need to look at the task requirements and follow it.

MacDonald91 · 2026-02-07T15:34:54Z

I now have followed the correct steps required by the task list.

I added 6 sizes
I added email
I removed the results.html page.

cjyuan · 2026-02-13T14:33:10Z

@MacDonald91 It seems you have not yet pushed the latest changes to GitHub. There is no new commits on this branch.

The most recent commit "Update project", does not include the changes you mentioned:

I added 6 sizes
I added email
I removed the results.html page.

A-O-Emmanuel

I have left some comments for you.

A-O-Emmanuel · 2026-02-14T17:06:43Z

+          <legend>Choose your T-shirt</legend>
+
+          <label for="name">Name:</label>
+          <input type="text" id="name" name="name" required />


can you find another way to make sure that the name is a valid name?

A-O-Emmanuel · 2026-02-14T17:07:08Z

+
+          <label for="colour">Colour:</label>
+          <select id="colour" name="colour" required>
+            <option value="">Select a colour</option>


select a colour should not be one of the options

A-O-Emmanuel · 2026-02-14T17:07:31Z

+
+          <label for="size">Size:</label>
+          <select id="size" name="size" required>
+            <option value="">Select a size</option>


select a size should not be one of the options

A-O-Emmanuel · 2026-02-14T17:09:47Z

You also need to ask the customer for their email, please go through the task requirements

MacDonald91 · 2026-02-19T14:49:59Z

Thank you for the feedback.

I have updated the form to fully align with the task requirements:

Added an email input field with built-in HTML validation.

Removed the form action attribute as instructed.

Removed duplicate meta and title tags.

Fixed the nested form structure.

Updated name validation using minlength="2" to define a valid name.

Updated colour and size selects to ensure users must choose from the defined options.

Added the required six size options (XS, S, M, L, XL, XXL).

Ensured all fields are required and properly associated with labels.

The form now satisfies all specified criteria and uses only semantic HTML and CSS.

Please let me know if further refinements are needed.

…e validation, remove form action, correct select options, and fix semantic structure

cjyuan · 2026-02-19T14:59:08Z

Changes look good. Well done.

github-actions · 2026-02-19T14:59:42Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-02-19T14:59:43Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-02-19T14:59:43Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

cjyuan · 2026-02-19T15:19:05Z

This branch should only contain changed files in the "Form-Controls" folder.

However, you made a commit on 9 Feb and modified Wireframe/index.html. That's why the validation bot is complaining.

The commit SHA (or hash) of the commit that modified Wireframe/index.html is dd37262.

Can you find out from ChatGPT

How to use "git restore" to revert the changes made to Wireframe/index.html by the commit with SHA dd37262?

and then revert the change made to Wireframe/index.html?

Complete form controls onboarding task

307611d

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

MacDonald91 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 26, 2026

A-O-Emmanuel reviewed Jan 27, 2026

View reviewed changes

A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 27, 2026

Update project

1b5bda1

MacDonald91 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

comp-lete task requirments

dd37262

MacDonald91 mentioned this pull request Feb 9, 2026

ITP-MAY-2026 | Onboarding | Alasdair MacDonald MacDonald91/My-Coursework-Planner#46

Open

A-O-Emmanuel reviewed Feb 14, 2026

View reviewed changes

A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 14, 2026

MacDonald91 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

Refactor form to meet task requirements: add email field, improve nam…

edd78f3

…e validation, remove form action, correct select options, and fix semantic structure

MacDonald91 closed this May 4, 2026

Uh oh!

Conversation

MacDonald91 commented Jan 26, 2026

Changelist

Uh oh!

netlify Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

A-O-Emmanuel left a comment

Choose a reason for hiding this comment

Uh oh!

MacDonald91 commented Feb 7, 2026

Uh oh!

cjyuan commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

A-O-Emmanuel left a comment

Choose a reason for hiding this comment

Uh oh!

A-O-Emmanuel Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

A-O-Emmanuel Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

A-O-Emmanuel Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

A-O-Emmanuel Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

MacDonald91 commented Feb 19, 2026

Uh oh!

cjyuan commented Feb 19, 2026

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

cjyuan commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Jan 26, 2026 •

edited

Loading

cjyuan commented Feb 13, 2026 •

edited

Loading