Skip to content

Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 2 | Form Controls #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RomanSanaye wants to merge 2 commits into from
Closed

Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 2 | Form Controls #1047

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dc7115
The Form was created based on the Criteria
RomanSanaye Jan 24, 2026
b575cee
Form UX updated: dropdowns added with placeholders
RomanSanaye Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 82 additions & 7 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,92 @@
<header>
<h1>Product Pick</h1>
</header>

<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<!-- Requirements:
- Collect customer's name (minimum 2 characters)
- Collect a valid email address
- Allow selection of 1 colour from 3 options
- Allow selection of 1 size from 6 options
- All fields are required
- HTML only (no CSS, no JavaScript)
- No form action
-->

<!-- Name -->
<div>
<label for="name">Name</label>
<input type="text" id="name" name="name" minlength="2" required />
Copy link
Copy Markdown

@takanocap takanocap Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a placeholder could be a way to guide users

Copy link
Copy Markdown
Author

@RomanSanaye RomanSanaye Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takanocap , Thank you for your valuable feedback. I followed your suggestion to add placeholders and reduce repeated HTML elements by using dropdowns, which made my form cleaner, more precise, and user-friendly. I also learned that there is always an alternative approach that can make a solution more elegant and efficient. I really appreciate your guidance.

</div>

<!-- Email -->
<div>
<label for="email">Email</label>
<input type="email" id="email" name="email" required />
Copy link
Copy Markdown

@takanocap takanocap Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welldone for the Good work.
can you add a placeholder to guide the user ?
can you use minlength as part of the validation for the email too ?

</div>

<!-- Colour -->
<fieldset>
<legend>T-Shirt Colour</legend>

<div>
<input type="radio" id="red" name="colour" value="red" required />
<label for="red">Red</label>
</div>

<div>
<input type="radio" id="blue" name="colour" value="blue" />
<label for="blue">Blue</label>
</div>

<div>
<input type="radio" id="green" name="colour" value="green" />
<label for="green">Green</label>
</div>
</fieldset>

<!-- Size -->
<fieldset>
<legend>T-Shirt Size</legend>
Copy link
Copy Markdown

@takanocap takanocap Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't want to type so many html elements i.e follow the KISS principle can we use the dropdown menu instead ?


<div>
<input type="radio" id="xs" name="size" value="XS" required />
<label for="xs">XS</label>
</div>

<div>
<input type="radio" id="s" name="size" value="S" />
<label for="s">S</label>
</div>

<div>
<input type="radio" id="m" name="size" value="M" />
<label for="m">M</label>
</div>

<div>
<input type="radio" id="l" name="size" value="L" />
<label for="l">L</label>
</div>

<div>
<input type="radio" id="xl" name="size" value="XL" />
<label for="xl">XL</label>
</div>

<div>
<input type="radio" id="xxl" name="size" value="XXL" />
<label for="xxl">XXL</label>
</div>
</fieldset>

<button type="submit">Submit</button>
</form>
</main>

<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h2>By Ahmad Roman Sanaye</h2>
</footer>
</body>
</html>
</html>