Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 2 | Form Controls#1047
Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 2 | Form Controls#1047RomanSanaye wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
RomanSanaye
added
the
Needs Review
| <!-- Email --> | ||
| <div> | ||
| <label for="email">Email</label> | ||
| <input type="email" id="email" name="email" required /> |
There was a problem hiding this comment.
welldone for the Good work.
can you add a placeholder to guide the user ?
can you use minlength as part of the validation for the email too ?
|
|
||
| <!-- Size --> | ||
| <fieldset> | ||
| <legend>T-Shirt Size</legend> |
There was a problem hiding this comment.
if we don't want to type so many html elements i.e follow the KISS principle can we use the dropdown menu instead ?
| <!-- Name --> | ||
| <div> | ||
| <label for="name">Name</label> | ||
| <input type="text" id="name" name="name" minlength="2" required /> |
There was a problem hiding this comment.
a placeholder could be a way to guide users
There was a problem hiding this comment.
@takanocap , Thank you for your valuable feedback. I followed your suggestion to add placeholders and reduce repeated HTML elements by using dropdowns, which made my form cleaner, more precise, and user-friendly. I also learned that there is always an alternative approach that can make a solution more elegant and efficient. I really appreciate your guidance.
takanocap
added
Reviewed
takanocap
added
Complete
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
3 participants
Self checklist
Changelist
This PR adds an HTML-only form to collect customer details for a t-shirt order.
The form uses semantic HTML, includes associated labels for all inputs, and applies native HTML validation to ensure all required fields are completed correctly. No CSS or JavaScript has been used, in line with the assignment requirements.
Questions
No questions at the moment. Feedback is welcome.