-
-
Notifications
You must be signed in to change notification settings - Fork 439
Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 1 | Wireframe #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3aad5d9
Update index.html and style.css for GitHub Learning project
Darkidd77 81ee296
Add CSS reset and new images for GitHub wireframe
Darkidd77 3b741ec
Refine image alt text and enhance CSS styles for layout and responsiv…
Darkidd77 775e6d8
Remove obsolete image and update image references in HTML Fixed the v…
Darkidd77 f591f1d
Refactor HTML structure removing unnecessary section tags to fix the…
Darkidd77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Embedding an image as base64-encoded string in HTML makes reading and editing the HTML code difficult.
A better practice is to save the images as an external files.
Can you save all three images as external file? Alternatively, you can just use
placeholder.svgin all three articles. Since this is a wireframe implementation, it does not matter much what images you use as the placeholders.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted! Will start doing the fixes now, much appreciated CJ.