London | Jan-26 | Maryannne Mosonik | Sprint 1 | Wireframe to Web Code #1014
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,13 +10,13 @@ | |
| <header> | ||
| <h1>Wireframe</h1> | ||
| <p> | ||
| Changes have been made here. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title 1</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
|
|
@@ -26,7 +26,51 @@ <h2>Title</h2> | |
| </main> | ||
| <footer> | ||
| <p> | ||
| Changes have been made here. | ||
| </p> | ||
| </footer> | ||
| <header> | ||
|
There was a problem hiding this comment. The header is never below the footer. Check on this
Author
There was a problem hiding this comment. @codeschris Kindly check, I have deleted the header and footer. |
||
| <h1>Wireframe</h1> | ||
| <p> | ||
| Changes have been made here. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title 2</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <p> | ||
| Changes have been made here. | ||
| </p> | ||
| </footer> | ||
| <header> | ||
|
There was a problem hiding this comment. The header should be one across the entire page. Check on this and make changes |
||
| <h1>Wireframe</h1> | ||
| <p> | ||
| Changes have been made here. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title 3</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
|
Maryanne-K marked this conversation as resolved.
|
||
| <p> | ||
| Changes have been made here. | ||
| </p> | ||
| </footer> | ||
| </body> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider having a single main tag and all articles inside that one main tag than repeating the main tag. Otherwise, everything else looks well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codeschris Kindly check corrected code.