Skip to content

Glasgow| 26-ITP-Jan|Fattouma Ouannassi| Sprint 2 | Form Controls #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FAprogrammerO wants to merge 2 commits into from
Closed

Glasgow| 26-ITP-Jan|Fattouma Ouannassi| Sprint 2 | Form Controls #1000

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
314bce2
Glasgow| 26-ITP-Jan|Fattouma Ouannassi| Sprint 2 | Form Controls
FAprogrammerO Jan 20, 2026
709c10a
Fix HTML issues from PR review
FAprogrammerO Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 43 additions & 8 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,51 @@
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
<form><libel for="name">Customer name:</libel><br>
<input
type="text"
id="name"
title="Name must contain only letters and spaces"><br><br>

Copy link
Copy Markdown

@A-O-Emmanuel A-O-Emmanuel Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you come up with a better way to check if customer name is a valid name?

Copy link
Copy Markdown
Author

@FAprogrammerO FAprogrammerO Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done✅

<label for="email">Email Address</label>
<br>
<input
type="email"
id="email"
name="email"
required>
<br><br>
Copy link
Copy Markdown

@A-O-Emmanuel A-O-Emmanuel Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also come up with a better way to check if Email address is a valid email address.

Copy link
Copy Markdown
Author

@FAprogrammerO FAprogrammerO Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done✅

<label for="colour">T-Shirt Colour:</label>
<br>
<select id="colour" name="colour"required>
<option value="select a colour">Select a colour</option>
Copy link
Copy Markdown

@A-O-Emmanuel A-O-Emmanuel Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select a colour is not supposed to be part of the option value

Copy link
Copy Markdown
Author

@FAprogrammerO FAprogrammerO Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

<option value="Pink">Pink</option>
<option value="Aqua">Aqua</option>
<option value="White">White</option>
</select>
<br><br>
<fieldset>
<legend>T-Shirt Size</legend>
<input type="radio" id="xs" name="size" value="xs">
<label for="xs">xs</label>
<input type="radio" id="s" name="size" value="s">
<label for="s">s</label>
<input type="radio" id="m" name="size" value="m">
<label for="m">m</label>
<input type="radio" id="l" name="size" value="l">
<label for="l">l</label>
<input type="radio" id="xl" name="size" value="xl">
<label for="xl">xl</label>
<input type="radio" id="xxl" name="size" value="xxl">
<label for="xxl">xxl</label>

</fieldset>

</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<!-- Fattouma Ouannassi-->
<h2>Fattouma Ouannassi</h2>
</footer>
</body>
</html>