NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | Quote Generator #803

TzeMingHo · 2025-10-26T17:09:42Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have made the quote generator work on my web browser. However, the second test fails.

Questions

Could I get some hints on why the second test: can change quote to another random quote (8 ms) fails? Even though I can actually change the quote randomly by clicking the new quote button.

github-actions · 2025-10-26T17:10:00Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-26T17:10:18Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-26T17:10:19Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T00:05:11Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T00:05:11Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T00:05:16Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

sambabib · 2025-11-01T00:18:32Z

Sprint-3/quote-generator/quotes.js

+  updateQuoteAndAuthor();
+  document
+    .getElementById("new-quote")
+    .addEventListener("click", updateQuoteAndAuthor);


You have implemented the first part of this task quite well. However, you have yet to attempt the "auto-generate" task. Why is that?

I was concerned that I couldn't figure out why the second test keeps failing. So, I made this pull request to seek for guidelines. However, if it is ok to move on, I would love to try implementing new features.

Hi sambabib,
I have added an auto-update feature for the quote generator.

github-actions · 2025-11-01T00:19:03Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T00:19:04Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T14:36:01Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T14:36:01Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T14:36:03Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-03T14:36:30Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

mjpeet · 2025-11-05T14:50:45Z

@TzeMingHo for some reason the github action thinks some of the template fields have not been filled properly

the only thing i can see is the title maybe?

if you look at this PR #788

--> the title says Quote Generator (at the end (without dash), can you try and rename your PR? (if you get any more github action issues, try to see what the difference is against the above mentioned PR)

cifarquhar · 2025-11-06T14:57:13Z

@sambabib @mjpeet When you next look at this could you see if the tests pass? I had a look at this with @TzeMingHo in a paired session this morning and the can change quote to another random quote test gives an assertion error - it looks like the text isn't updating. I saw the app working though, it's updating the DOM correctly. Doesn't look like it's been flagged in any other PRs for this exercise. Have I missed a bug, or do you think the test is checking the value before the function has finished updating it?

making the quote app works but failing the second test

21aa7aa

TzeMingHo added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

TzeMingHo added 2 commits October 26, 2025 17:11

updated index.html

081238f

added css styling

ffe6668

sambabib reviewed Nov 1, 2025

View reviewed changes

sambabib added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 1, 2025

TzeMingHo mentioned this pull request Nov 2, 2025

NW | 25-ITP-Sep | Data groups | TzeMing Ho TzeMingHo/My-Coursework-Planner#40

Open

TzeMingHo added 2 commits November 2, 2025 18:06

adding a toggle button

75d1246

implemented auto generator

4e2d6df

TzeMingHo added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 3, 2025

TzeMingHo requested a review from sambabib November 5, 2025 15:35

Uh oh!

NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | Quote Generator #803

Are you sure you want to change the base?

NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | Quote Generator #803

Conversation

TzeMingHo commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

sambabib Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

TzeMingHo Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

TzeMingHo Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

mjpeet commented Nov 5, 2025

Uh oh!

cifarquhar commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TzeMingHo commented Oct 26, 2025 •

edited

Loading