London | 25-ITP-Sep | Adnaan Abo | Sprint 1 | Sprint-1 #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: Sprint-1/fix/median.test.js new file: package-lock.json new file: package.json
modified: Sprint-1/implement/dedupe.test.js
modified: Sprint-1/implement/max.test.js
modified: Sprint-1/implement/sum.test.js
modified: Sprint-2/debug/address.js
modified: Sprint-2/implement/contains.test.js
modified: Sprint-2/implement/lookup.test.js
modified: Sprint-2/implement/querystring.test.js
modified: Sprint-2/implement/tally.test.js
deleted: Sprint-2/debug/author.js deleted: Sprint-2/debug/recipe.js deleted: Sprint-2/implement/contains.js deleted: Sprint-2/implement/contains.test.js deleted: Sprint-2/implement/lookup.js deleted: Sprint-2/implement/lookup.test.js deleted: Sprint-2/implement/querystring.js deleted: Sprint-2/implement/querystring.test.js deleted: Sprint-2/implement/tally.js deleted: Sprint-2/implement/tally.test.js deleted: Sprint-2/interpret/invert.js deleted: Sprint-2/package-lock.json deleted: Sprint-2/package.json deleted: Sprint-2/readme.md deleted: Sprint-2/stretch/count-words.js deleted: Sprint-2/stretch/mode.js deleted: Sprint-2/stretch/mode.test.js deleted: Sprint-2/stretch/till.js
modified: Sprint-1/implement/sum.test.js
AdnaanA
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Change list:
In sum.js I have implemented a function that sums only the numeric elements of an array, ignoring non-numerical values, and handles empty arrays, negatives, and decimals, with tests in sum.test.js.
In max.js I have implemented a function that finds the largest numeric element in an array while ignoring non-numeric values and supporting empty arrays, negatives, and decimals, tested in max.test.js.
In dedupe.js I have implemented a function that removes duplicate values from arrays of numbers or strings, preserving the first occurrence and handling empty arrays, with tests in dedupe.test.js.
In calculateMedian.js I have implemented a function that calculates the median of numeric elements from sorted or unsorted arrays of odd or even length, filtering out non-numeric values, tested in median.test.js.
In includes.js I have refactored the function that checks if a target value exists in an array using a for...of loop, supporting empty arrays, duplicates, and nulls, with tests in includes.test.js.