Skip to content

NW6 | Hadika Malik | HTML-CSS | Module-Project | Week 1 + Week 2 #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HadikaMalik wants to merge 14 commits into
base: master
Choose a base branch
from
Open

NW6 | Hadika Malik | HTML-CSS | Module-Project | Week 1 + Week 2 #639

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
90603d5
draft 1
HadikaMalik Sep 27, 2023
a829614
draft 1
HadikaMalik Sep 27, 2023
4764489
draft 2
HadikaMalik Sep 28, 2023
94623e8
draft2
HadikaMalik Sep 28, 2023
d22b047
final version
HadikaMalik Sep 30, 2023
5fd3daf
level 2 feature homepage draft 1
HadikaMalik Oct 4, 2023
8d52894
homepage addition
HadikaMalik Oct 5, 2023
316c426
trial for feedback css styling
HadikaMalik Oct 6, 2023
229b06f
feedback implemented added homepage feature
HadikaMalik Oct 9, 2023
83e2062
speechmarks colour added
HadikaMalik Oct 9, 2023
59f1491
semantic html
HadikaMalik Oct 9, 2023
daa5cd5
semantic htmls draft
HadikaMalik Oct 11, 2023
e726eb2
form completed, radio check button arrow left
HadikaMalik Oct 13, 2023
4a87ccf
final version
HadikaMalik Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 142 additions & 9 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,147 @@ body {
-webkit-font-smoothing: antialiased;
}

/**
* Add your custom styles below
*
* Remember:
* - Be organised, use comments and separate your styles into meaningful chunks
* for example: General styles, Navigation styles, Hero styles, Footer etc.
*
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex'
*/
h1,
h2,
h3,
h4,
h5,
h6,
p{
font-weight: lighter;
}

/* .header,
.main,
.footer{
padding: 0 1.5rem;
max-width: 1200px;
margin: 0 auto;
} */

.header{
display: flex;
align-items: center;
justify-content: space-between;
height: 5rem;
margin: 2px 100px;
}

.header_logo{
width: 20px;
height: 10rem;
}

.navigation_list{
display: flex;
align-items: center;
list-style: none;
}

.navigation_item{
padding: 20px;
font-size: large;
}

.navigation_link{
text-decoration: none;
color: grey;
}

.navigation_link:hover{
color: rgba(214, 65, 12, 0.842);
}

.main{
background-image: url(../img/first-background.jpg);
background-repeat: no-repeat;
background-position: center;
color: white;
padding: 80px;
text-align: center;
font-size: xx-large;
margin: 5px 40px;
}

.main h1{
margin-top: 7rem;
}

.main p{
margin-bottom: 4rem;
}

.main button{
margin-bottom: 10rem;
background-color: rgba(214, 65, 12, 0.842);
color: white;
padding: 20px 50px;
border-radius: 10px;
}

.second_heading{
text-align: center;
margin-top: 5rem;
font-size: 50px;
}

.container{
display: flex;
align-items: center;
justify-content: center;
margin-bottom: 4rem;
}

.images{
width: 200px;
}

.article_title{
font-size: 40px;
text-wrap: nowrap;
}

.articles{
padding: 20px 40px;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
}

/* .container{
Copy link

@bunday bunday Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, as best practice, its better to remove code sections you are not using, instead of commenting it out

display: grid;
align-items: center;
justify-content: center;
grid-gap: 200px;
grid-template-columns: 200px 200px 200px;
grid-template-rows: 50px 300px;
} */

.footer{
display: flex;
align-items: center;
justify-content: center;
text-align: center;
}

.footer p {
font-size: 20px;
}

.copyright{
color: lightgray;
}

.footer_img{
padding: 10px;
width: 20px;
height: 20px;
border: solid 1px lightgray;
border-radius: 50%;
margin: 5px;
}

hr{
width: 90%;
}
95 changes: 92 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,99 @@
<link rel="shortcut icon" type="image/x-icon" href="favicon.ico">
</head>
<body>
<header class="header">
<a href="#">
<img
src="img/karma-logo.svg"
alt="karma logo"
class="header_logo"
/>
</a>
<nav>
<ul class="navigation_list">
<li class="navigation_item">
<a class="navigation_link" href="#">Meet Karma</a>
Copy link

@bunday bunday Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this item is of color black.

</li>
<li class="navigation_item">
<a class="navigation_link" href="#">How it Works</a>
</li>
<li class="navigation_item">
<a class="navigation_link" href="#">Store</a>
</li>
<li class="navigation_item">
<a class="navigation_link" href="#">Blog</a>
</li>
<li class="navigation_item">
<a class="navigation_link" href="#">Help</a>
</li>
<li class="navigation_item">
<a class="navigation_link" href="#">Login</a>
</li>
</ul>
</nav>
</header>

<!-- Add your HTML markup here -->
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
<!-- All the images you need are in the 'img' folder -->
<main class="content">
<section class="main">
<h1>Introducing Karma</h1>
<p>Bring WiFi with you, everywhere you go.</p>
<button class="orange-button">Learn More</button>
Copy link

@bunday bunday Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this class orange-button doesnt exist in your css, you can remove unused classes. Also, this button seems to have a border width on it, can you remove it?

</section>
<section class="points">
<h2 class="second_heading">Everyone needs a little Karma.</h2>

<section class="container">
<article class="articles">
<img
class="images"
src="img/icon-devices.svg"
alt="devices image"
/>
<p class="article_title">Internet for all devices</p>
</article>

<article class="articles">
<img
class="images"
src="img/icon-coffee.svg"
alt="devices image"
/>
<p class="article_title">Boost your productivity</p>
</article>

<article class="articles">
<img
class="images"
src="img/icon-refill.svg"
alt="devices image"
/>
<p class="article_title">Pay as You Go</p>
</article>
</section>

</section>
</main>
<hr>
Copy link

@bunday bunday Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the color for this element is a bit different

<footer class="footer">
<section class="footer_content">
<p>Join us on</p>
<img
class="footer_img"
src="img/twitter-icon.svg"
alt="twitter-icon"
/>
<img
class="footer_img"
src="img/facebook-icon.svg"
alt="facebook-icon"
/>
<img
class="footer_img"
src="img/instagram-icon.svg"
alt="instagram-icon"
/>
<p class="copyright">@Karma Mobility Inc.</p>
</section>
</footer>
</body>
</html>