fix: fixing issue with async error handling within the SERVERLESS_EXPRESS:PROXY #708
+99
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type string This was identified through using express within AWS Lambda which returns content-length header as a number which causes ALB to throw a 502 bad gateway exception. This change fixes this issue.
… type string This was identified through using express within AWS Lambda which returns content-length header as a number which causes ALB to throw a 502 bad gateway exception. This change fixes this issue.
…RESS:PROXY This change handles non-async and async errors thrown within `forwardRequestToNodeServer` and adds an integration test (this was previously skipped).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change handles non-async and async errors thrown within
forwardRequestToNodeServerand adds an integration test (this was previously skipped).Our implementation using ALB -> Lambda has resulted in Lambda crashes due to unhandled malformed
URIErrors. Currently, these errors bypassrespondToEventSourceWithError, resulting in hard crashes. This change fixes this issue.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.