Skip to content

chore: add ARM image build support #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

Conversation

VinneyJ
Copy link
Contributor

@VinneyJ VinneyJ commented Oct 8, 2024

Description

Add ARM image build support for the ARM architectures.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@VinneyJ VinneyJ requested a review from a team October 9, 2024 06:06
@kilemensi
Copy link
Member

No need for reviews on this one @VinneyJ, we're switching to callable workflows so multi platform build will be added after that. Otherwise, PRs will just take too long to build.

Use this branch to temporarily build and deploy to arm64 instances but don't merge it.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-938 Visit

@kilemensi kilemensi mentioned this pull request Oct 16, 2024
8 tasks
@koechkevin
Copy link
Contributor

@CodeForAfrica/tech ready for review

@koechkevin koechkevin requested a review from thepsalmist May 12, 2025 11:06
@kilemensi
Copy link
Member

Were we going to merge this @koechkevin / @thepsalmist or not?

@koechkevin
Copy link
Contributor

Were we going to merge this @koechkevin / @thepsalmist or not?

@kilemensi yes, this PR is good to merge except for a concern that builds will take longer, which if the case we just use it for deployments but keep up to date.

@kilemensi
Copy link
Member

Cool, @koechkevin but we need automatic DEV deployments on merge to main at least for trustlab. Given that both ui-1.dev and ui-2.prod are arm64, shouldn't we just build arm64 images instead of building both amd64 and arm64?

cc @CodeForAfrica/tech

PS: These are the only apps currently deployed in amd64 instance:

  • maternal-figures-ui
  • nigerianstat-ui
  • twoopstracker-ui

We've already migrated twoopstracker-ui to ui repo so 🤞🏽 it'll be running on arm64 soon if not already there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants