Bump golang.org/x/crypto from 0.31.0 to 0.42.0 #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
changed the title
go mod tidy in example/*.
AkihiroSuda
reviewed
Aug 27, 2025
example/gui-linux/go.mod
Outdated
| module github.com/Code-Hex/vz/example/gui-linux | ||
|
|
||
| go 1.22.0 | ||
| go 1.23.0 |
There was a problem hiding this comment.
Now Go 1.22 CI seems useless, as it is automatically updated to Go 1.23
vz/.github/workflows/compile.yml
Line 35 in 5bbaec6
Setting GOTOOLCHAIN=local will prevent the auto update.
|
@cfergeau Could you handle this PR? 🙏 |
cfergeau
force-pushed
the
crypto-0.35.0
branch
from
d3d05ee to
2370251
Compare
I’ve updated the PR:
|
cfergeau
changed the title
This ensures GOTOOLCHAIN is set to `local`, which avoids silent downloads of newer go versions when the version in `go.mod` is newer than is specified in the workflow definition. Signed-off-by: Christophe Fergeau <[email protected]>
These are the 2 versions which are currently supported upstream. Signed-off-by: Christophe Fergeau <[email protected]>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.31.0 to 0.42.0. - [Commits](golang/crypto@v0.31.0...v0.42.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.42.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Christophe Fergeau <[email protected]>
By telling it there are go.mod files in example/*, hopefully this will limit the need for commits where we run `go mod tidy` ourselves. Signed-off-by: Christophe Fergeau <[email protected]>
With newer go versions, `go vet` reports: ``` cmd/addtags/main.go:19:25: non-constant format string in call to fmt.Fprintf cmd/addtags/main.go:24:25: non-constant format string in call to fmt.Fprintf ``` This happens because of the use of [1:] to remove an unwanted `\n` at the beginning of the string. This commit switches to `Fprint` instead of `Fprintf` as there are no substitutions to be made in the string. Signed-off-by: Christophe Fergeau <[email protected]>
cfergeau
force-pushed
the
crypto-0.35.0
branch
from
bdf8f37 to
2bc6eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #190 and hopefully fixes the CI failures by running
go mod tidyinexample/*.