Skip to content

Commit

Permalink
fixed checkbox preferences bug and updated readme
Browse files Browse the repository at this point in the history
  • Loading branch information
babyman committed Dec 5, 2012
1 parent 285bb49 commit 8620b4b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
12 changes: 6 additions & 6 deletions quick-tabs/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,25 +29,25 @@ $(document).ready(function() {
displayKey("close_all", closeAllTabsKey);

$("#closed_tabs_size").val(bg.getClosedTabsSize());
$("#search_string").val(bg.getSearchString());
$("#search_delay").val(bg.getSearchDelay());
$("#show_dev_tools").attr('checked', bg.showDevTools());
$("#show_urls").attr('checked', bg.showUrls());
$("#show_tooltips").attr('checked', bg.showTooltips());
$("#show_favicons").attr('checked', bg.showFavicons());
$("#search_string").val(bg.getSearchString());
$("#search_delay").val(bg.getSearchDelay());

$("#save_btn").click(function() {
bg.setShortcutKey(assignKeyProperties("popup", popup_key));
bg.setCloseTabKey(assignKeyProperties("close", closeTabKey));
bg.setCloseAllTabsKey(assignKeyProperties("close_all", closeAllTabsKey));

bg.setClosedTabsSize($("#closed_tabs_size").val());
bg.setShowUrls($("#show_urls").attr('checked'));
bg.setShowTooltips($("#show_tooltips").attr('checked'));
bg.setShowFavicons($("#show_favicons").attr('checked'));
bg.setSearchString($("#search_string").val());
bg.setSearchDelay($("#search_delay").val());
bg.setShowDevTools($("#show_dev_tools").attr('checked'));
bg.setShowUrls($("#show_urls").is(':checked'));
bg.setShowTooltips($("#show_tooltips").is(':checked'));
bg.setShowFavicons($("#show_favicons").is(':checked'));
bg.setShowDevTools($("#show_dev_tools").is(':checked'));

bg.rebindShortcutKeys();

Expand Down
7 changes: 5 additions & 2 deletions readme.textile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
h2. LICENSE

Copyright (c) 2009 - 2011, Evan Jehu
Copyright (c) 2009 - 2012, Evan Jehu
All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
Expand Down Expand Up @@ -40,6 +40,8 @@ h2. FEATURES
* tab list shortcut keys:
** to close selected tab (default ctrl+d)
** to close ALL displayed tabs in the tab list, honors search filtering (default shift+ctrl+d)
** select next tab (ctrl+n)
** select previous tab (ctrl+p)



Expand Down Expand Up @@ -70,7 +72,6 @@ h2. FEEDBACK AND BUGS
Please report all your valuable feedback, feature requests and bug reports on the github "issues page":http://github.com/babyman/quick-tabs-chrome-extension/issues for this extension.



h2. CHROME API WISH LIST

* shortcut keys for browser action extensions - this would allow the extension to work with only "tab" permissions and not require access to the users computer simply to run its contentScript :|
Expand All @@ -79,6 +80,8 @@ h2. CHROME API WISH LIST

h2. RELEASE NOTES

2012.12.4 - applied patches from konk303 (line hight, ctrl+n/ctrl+p tab select keyboard shortcuts), ignacysokolowski (search delay option and integer parse bug) and slay2k (huge code update, library version updates, performance improvements and improved search matching)

2011.2.18 - applied patches from yaauie, option to set search provider, open popup in the middle of current window, compatible with multiple monitors

2010.6.27 - applied crtl+D tab close tab focus enhancement patch from osheroff
Expand Down

0 comments on commit 8620b4b

Please sign in to comment.