Skip to content

Commit

Permalink
separate mouse hover style from keyboard navigation focus to prevent …
Browse files Browse the repository at this point in the history
…focus jumps when the popup opens under the mouse pointer, refs babyman#72
  • Loading branch information
babyman committed Mar 8, 2015
1 parent f93d757 commit 0ad1f56
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 9 deletions.
15 changes: 11 additions & 4 deletions quick-tabs/assets/styles-popup.css
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ body {
padding: 8px 5px 7px 5px;
margin: 0;
width: 100%;
border: 1px solid #cdcdcd;
outline: none;
border: none;
border-bottom: 1px solid #4285f4;
Expand Down Expand Up @@ -95,6 +94,7 @@ div.hideicon {
height: 25px;
}

div.open:hover div.close,
div.withfocus.open div.close {
display: inline;
position: relative;
Expand All @@ -105,10 +105,9 @@ div.withfocus.open div.close {
}

div.close {
background-image: url(close.png);
background: url(close.png) no-repeat;
background-size: 12px 12px;
background-repeat: no-repeat;
display: none;
display: none;
height: 18px;
width: 18px;
cursor: pointer;
Expand Down Expand Up @@ -158,6 +157,14 @@ div.content {
background: white;
}

.item:hover, .item:hover div.title, div.closed.item:hover div.title,
.item:hover div.url {
background-color: #ff8732;
color: white;
}

.withfocus:hover, .withfocus:hover div.title, div.closed.withfocus:hover div.title,
.withfocus:hover div.url,
.withfocus, .withfocus div.title, div.closed.withfocus div.title,
.withfocus div.url {
background-color: #4285f4;
Expand Down
2 changes: 1 addition & 1 deletion quick-tabs/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"permissions": [ "tabs", "bookmarks" ],
"update_url": "http://clients2.google.com/service/update2/crx",

"version": "2015.3.3",
"version": "2015.3.8",

"sandbox": {
"pages": ["sandbox.html"]
Expand Down
4 changes: 0 additions & 4 deletions quick-tabs/popup.js
Original file line number Diff line number Diff line change
Expand Up @@ -393,10 +393,6 @@ window.addEventListener('message', function(event) {
openInNewTab(this.getAttribute('data-path'));
});

$('.item').on('mouseover', function() {
focus($(this));
});

$('.close').on('click', function() {
closeTabs([parseInt(this.id.substring(1))])
});
Expand Down
2 changes: 2 additions & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ Please report all your valuable feedback, feature requests and bug reports on th

# RELEASE NOTES

2015.3.8 - popup window timers, separate mouse hover style from keyboard navigation focus to prevent focus jumps when the popup opens under the mouse pointer

2015.3.3 - popup window cleanup, search urls only if displayed

2015.2.28 - library updates, better scrolling, search bookmarks by starting or ending your search string with spaces
Expand Down

0 comments on commit 0ad1f56

Please sign in to comment.