added create user endpoint and unit tests for users #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juwang110
requested changes
Oct 5, 2025
Juwang110
left a comment
Juwang110
left a comment
There was a problem hiding this comment.
Overall looks good, just requires some refactoring, nice work!
sam-schu
reviewed
Nov 6, 2025
sam-schu
reviewed
Nov 9, 2025
…H/ssf-53-create-user-endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes 53
📝 Description
Added a create users endpoint to /users in backend. This endpoint uses email, firstName, lastName, phone, role to create a user. I also had to modify the userService create function to not use the preset id and to have the phone field. I created unit tests for the user controller and user service to test the user routes.
✔️ Verification
I tested my route using Jest and created a sample user. I ran all of my tests and they passed.
🏕️ (Optional) Future Work / Notes
I had to slightly change the authController and sign_updto to include the phone field in order to pass the tests, since the create function in the userService was altered.