Skip to content

Fix some of the typing broken in #81 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix some of the typing broken in #81 #84

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b099733
Fix some of the typing broken in #81
flying-sheep Jul 10, 2025
fc4e319
fix imports
flying-sheep Jul 24, 2025
8a52731
Merge branch 'master' into patch-1
flying-sheep Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/pytest_codspeed/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@
from . import __version__

if TYPE_CHECKING:
from typing import Any, Callable, TypeVar
from typing import Any, Callable, ParamSpec, TypeVar

from pytest_codspeed.instruments import Instrument

T = TypeVar("T")
P = ParamSpec("P")


@pytest.hookimpl(trylast=True)
Expand Down Expand Up @@ -328,9 +329,7 @@ def __init__(self, request: pytest.FixtureRequest):
self._plugin = get_plugin(self._config)
self._called = False

def __call__(
self, target: Callable[..., T], *args: tuple, **kwargs: dict[str, Any]
) -> T:
def __call__(self, target: Callable[P, T], *args: P.args, **kwargs: P.kwargs) -> T:
if self._called:
raise RuntimeError("The benchmark fixture can only be used once per test")
self._called = True
Expand Down