Fix some of the typing broken in #81 #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for the contribution. Happy to merge this once you get the CI passing, the type checking is failing ;) |
CodSpeed Instrumentation Performance ReportMerging #84 will not alter performanceComparing Summary
|
This comment was marked as outdated.
This comment was marked as outdated.
|
hello? |
|
Merged in 44071fc |
|
Thanks for the contribution |
|
great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #81 (comment)
I don’t know which other public APIs’ typing were broken by that PR. Maybe you should run a type checker in CI to avoid breakage like this.