Fix invalid call to VirtualProtect#27
Merged
Belonit merged 2 commits intoCnCNet:mainfrom Feb 20, 2025
shmocz:fix/virtualprotect-call
Merged
Fix invalid call to VirtualProtect#27Belonit merged 2 commits intoCnCNet:mainfrom shmocz:fix/virtualprotect-call
Belonit merged 2 commits intoCnCNet:mainfrom
shmocz:fix/virtualprotect-call
Conversation
VirtualProtect fails if fourth argument is NULL, see: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualprotect On some versions of wine this leads to null pointer dereference and crash.
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Member
|
@shmocz Microsoft doc says that we should also use the FlushinstructionCache function, what do you think about this? |
Contributor
Author
|
Based on quick search, self-modifying code should work on x86 systems without explicit cache flush. I suggest we still add it just to be consistent with documentation, with a comment clarifying that it's use isn't strictly necessary. |
ZivDero
added a commit
to Phobos-developers/Phobos
that referenced
this pull request
Mar 7, 2025
Fix incompatiblity with CnCNet/yrpp-spawner#27
ZivDero
added a commit
to Phobos-developers/Phobos
that referenced
this pull request
Mar 7, 2025
Fix incompatiblity with CnCNet/yrpp-spawner#27
ZivDero
added a commit
to Phobos-developers/Phobos
that referenced
this pull request
Mar 7, 2025
Fix incompatiblity with CnCNet/yrpp-spawner#27 Co-authored-by: Trsdy <[email protected]>
Coronia
pushed a commit
to Phobos-developers/Phobos
that referenced
this pull request
Mar 8, 2025
Fix incompatiblity with CnCNet/yrpp-spawner#27 Co-authored-by: Trsdy <[email protected]>
Metadorius
pushed a commit
to Metadorius/Phobos
that referenced
this pull request
Mar 30, 2025
…1551) Fix incompatiblity with CnCNet/yrpp-spawner#27 Co-authored-by: Trsdy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VirtualProtect fails if fourth argument is NULL, see: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualprotect
On some versions of wine this leads to null pointer dereference and crash.