Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiscordHandler cleanup. #236

Merged
merged 1 commit into from
Jun 29, 2021
Merged

DiscordHandler cleanup. #236

merged 1 commit into from
Jun 29, 2021

Conversation

Starkku
Copy link
Contributor

@Starkku Starkku commented Jun 27, 2021

  • Remove unnecessary using statements.
  • Remove unnecessary update method override.
  • Do not require restart when changing Discord integration setting.

@Starkku
DiscordHandler cleanup.
ee1489c 
- Remove unnecessary using statements.
- Remove unnecessary update method override.
- Do not require restart when changing Discord integration setting.
Metadorius
Metadorius reviewed Jun 28, 2021
View reviewed changes
Copy link
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I assume it works as before in other parts except the no restart part.

DXMainClient/Domain/DiscordHandler.cs Show resolved Hide resolved
@Metadorius Metadorius self-requested a review June 29, 2021 11:25
@Metadorius Metadorius merged commit bee3346 into master Jun 29, 2021
@Starkku Starkku deleted the fix/discord-handler branch June 29, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Metadorius Metadorius Metadorius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Starkku @Metadorius