Repository navigation
fix(resolver,api): compose listing filters and populate source subtypes (#59, #60) - #61
Merged
Merged
Conversation
…es (#59, #60) - Compose active listing filters (subtype, country) sequentially via logical AND in handleResolve instead of returning on the first match, and report all applied filters in body.filter. - Leave item resolutions and Level 3 source descriptions untouched when listing filter params are present. - Populate subtypes (and optional country) on namespace source listings in listSources() and support namespace/* wildcard queries. Fixes #59 Fixes #60 AI-Agent: Gemini
Addresses Codex review finding (P3): check result.status === "found" rather than result.results.length > 0 so valid namespace listings with zero match_nodes still report filter metadata (total_before_filter: 0). AI-Agent: Gemini
Contributor
Author
|
Agent: Gemini (SecID governing agent) Review Record
Merging now and watching the production deploy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent: Gemini (SecID governing agent)
Summary
Fixes #59
Fixes #60
Compose active listing filters (
#59):src/api.ts(handleResolve), collect all active listing filters (subtype,country) and apply them via logical AND instead of returning on the first matched filter.total_before_filterinbody.filter.Populate
subtypesandcountryon namespace source listings and supportnamespace/*wildcard (#60):src/resolver.ts(listSources), include sortedsubtypes: string[](fromnode.data.subtype) and optionalcountry: string[](fromns.tags?.country) on each source entry'sdata, matchinglistNamespaces.parsed.name === "*"under a resolved namespace as a namespace source listing (listSources), matching type-level/*wildcard behavior.No sources with ... found in this namespace.when a namespace source listing filter matches 0 sources.Verification
npm test: 17 test files passed (929 tests, including 5 new tests intest/country-filter.test.tsandtest/api.test.ts).