Skip to content

Fix profile completion percentage fluctuation #4828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Armaansaxena wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix profile completion percentage fluctuation #4828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6032240
Fix profile completion percentage fluctuation
Armaansaxena Dec 4, 2025
36d6d56
Fix seed.py file
Armaansaxena Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions frontend/src/js/controllers/profileCtrl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,23 +53,29 @@
var status = response.status;
var result = response.data;
if (status == 200) {
for (var i in result) {
if (result[i] === "" || result[i] === undefined || result[i] === null) {
if (i === "linkedin_url" || i === "github_url" || i === "google_scholar_url") {
result[i] = "";
} else {
result[i] = "";
}
vm.countLeft = vm.countLeft + 1;

var profileFields = ['first_name', 'last_name', 'affiliation', 'github_url', 'google_scholar_url', 'linkedin_url'];

// Reset counters to ensure stability
vm.countLeft = 0;
count = 0;

// Iterate only over the specific profile fields
profileFields.forEach(function(field) {
count++; // Total fields is always fixed (e.g., 6)

// Check if the field is empty/null/undefined
if (!result[field] || result[field] === "") {
result[field] = ""; // Ensure UI binds to empty string instead of null
vm.countLeft++;
}
count = count + 1;
}
vm.compPerc = parseInt((vm.countLeft / count) * 100);
});

vm.compPerc = parseInt(((count - vm.countLeft) / count) * 100);

vm.user = result;
vm.userdetails = angular.copy(result);
vm.user.complete = 100 - vm.compPerc;

vm.user.complete = vm.compPerc;
}
},
onError: function(response) {
Expand Down