Skip to content

[refactor/#369] sonarcloud 작동 확인 #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yongjun0511 merged 21 commits into from
Jul 4, 2025
Merged

[refactor/#369] sonarcloud 작동 확인 #370

yongjun0511 merged 21 commits into from
Jul 4, 2025

Conversation

@yongjun0511
Copy link
Contributor

@yongjun0511 yongjun0511 commented Jul 1, 2025 •
edited
Loading

📌 연관 이슈

🌱 PR 요약

  • sonarcloud가 작동하는지 확인용 PR

🛠 작업 내용

  • CI와 CD를 분리하여 CI에서는 이제 Test Coverage와 Test 통과 여부가 점검됩니다.
  • SonarCloud 작동확인

📸 스크린샷

❗️리뷰어들께

@yongjun0511 yongjun0511 linked an issue Jul 1, 2025 that may be closed by this pull request
[refactor] SonarCloud & JaCoCo 점검 및 리펙토링 #369
Closed
@yongjun0511 yongjun0511 self-assigned this Jul 1, 2025
@yongjun0511 yongjun0511 added 🔥 Fix Something isn't working ♻️ Refactor Extra attention is needed labels Jul 1, 2025
Ssamssamukja
Ssamssamukja reviewed Jul 2, 2025
View reviewed changes
src/main/java/com/clokey/server/global/config/JpaAuditingConfig.java
Copy link
Contributor

@Ssamssamukja Ssamssamukja Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따로 뺀 이유가 뭔가요??

Copy link
Contributor Author

@yongjun0511 yongjun0511 Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repository layer에서 @DataJpaTest를 수행하는데, 전체 Context를 로딩하지 않아서 createdAt과 updatedAt을 업데이트 할 때 에러가 생겨서 따로 config로 빼주었슴다.

Ssamssamukja
Ssamssamukja approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@Ssamssamukja Ssamssamukja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2025

Quality Gate Passed Quality Gate passed

Issues
25 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@yongjun0511 yongjun0511 merged commit b4f9dd3 into develop Jul 4, 2025
2 checks passed
@yongjun0511 yongjun0511 deleted the refactor/#369-refactor-sonarcloud-jacoco branch July 22, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ssamssamukja Ssamssamukja Ssamssamukja approved these changes

@2ghrms 2ghrms Awaiting requested review from 2ghrms

@juuuuone juuuuone Awaiting requested review from juuuuone

Assignees

@yongjun0511 yongjun0511

Labels

🔥 Fix Something isn't working ♻️ Refactor Extra attention is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[refactor] SonarCloud & JaCoCo 점검 및 리펙토링

3 participants

@yongjun0511 @Ssamssamukja