Add custom query settings support #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lio-p is attempting to deploy a commit to the ClickHouse Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -724,6 +730,7 @@ export async function getPackageRanking(package_name, min_date, max_date, countr | |||
| const columns = ['project', 'date'] | |||
| if (country_code) { columns.push('country_code') } | |||
| const table = findOptimalTable(columns) | |||
|
|
|||
| return query('getPackageRanking',`WITH | |||
There was a problem hiding this comment.
but query needto actually consume and send in the query...
There was a problem hiding this comment.
The custom settings are passed directly to the clickhouse.query function. See line 761 in clickhouse.js
gingerwizard
requested changes
Jan 12, 2025
|
i.e. |
gingerwizard
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to add custom query settings using environment variable.
Related: #119
Example:
Add automatically to the query getPackageRanking the query level settings
allow_experimental_parallel_reading_from_replicasandmax_threads