Complete ClickHouse server settings typings #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slvrtrn
commented
Aug 17, 2022
slvrtrn
commented
Aug 17, 2022
slvrtrn
commented
Aug 17, 2022
slvrtrn
commented
Aug 17, 2022
mshustov
approved these changes
Aug 18, 2022
mshustov
reviewed
Aug 18, 2022
| output_format_sql_insert_quote_names?: Bool | ||
| } | ||
|
|
||
| type Bool = 0 | 1 |
There was a problem hiding this comment.
It's also discussable whether we need to handle them as number or string. We don't work with them as numbers. Even worse, every client handles them differently:
Python as string
golang as number
jdbc as boolean
We should discuss it within the group and align behavior across the clients
slvrtrn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27