-
Notifications
You must be signed in to change notification settings - Fork 579
[jdbc-v2] Fixes in the PreparedStatementImpl class, the initial length of the parameters is incorrectly changed in the clearParameters method #2305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jielongping seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Good day, @CCweixiao! Thanks! |
…h of the parameters is incorrectly changed in the clearParameters method
Thanks a lot for the code review, I've submitted a test case for the corresponding code fix, please help me review again. @chernser |
} | ||
|
||
@Override | ||
String compileSql(String[] segments) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a good practice - if someone change an original method then test will not be verifying a production code.
Please just make compileSql
package private. This is ok because tests sometimes need to do so.
} | ||
} | ||
|
||
static class TestPreparedStatementImpl extends PreparedStatementImpl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this class.
@CCweixiao thanks! |
Your suggestion was taken and the test case modifications were completed @chernser |
@CCweixiao can you sign the CLA |
|
Summary
Closes #2299
Checklist
Delete items not relevant to your PR: