[perf] Added tests for data types (DateTime) #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
requested changes
Mar 25, 2025
performance/src/test/com/clickhouse/benchmark/BenchmarkRunner.java
Outdated
Show resolved
Hide resolved
| @@ -80,7 +81,7 @@ public static class DataState { | |||
|
|
|||
| @Param({"file://dataset_500k.csv"}) | |||
| String datasetSourceName; | |||
| @Param({"300000", "220000", "100000", "10000"}) | |||
| @Param({"300000", "100000", "10000"}) | |||
There was a problem hiding this comment.
is it just an experiment? or should keep this?
There was a problem hiding this comment.
I would keep it. It takes time for testing but doesn't give a new information, I think.
Fixing data size
mzitnik
reviewed
Mar 25, 2025
| @@ -249,6 +252,7 @@ protected static ClickHouseClient getClientV1() { | |||
| return ClickHouseClient.builder() | |||
| .defaultCredentials(ClickHouseCredentials.fromUserAndPassword(getUsername(), getPassword())) | |||
| .nodeSelector(ClickHouseNodeSelector.of(ClickHouseProtocol.HTTP)) | |||
| .option(ClickHouseClientOption.MAX_QUEUED_BUFFERS, 1) | |||
There was a problem hiding this comment.
is it a change in client config. Can you explain the effect of it
There was a problem hiding this comment.
sorry, I've missed it.
|
mzitnik
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds scaffolding and sample tests for data types.
Checklist
Delete items not relevant to your PR: