Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting date/time conversion #2095

Closed
wants to merge 1 commit into from
Closed

Adjusting date/time conversion #2095

wants to merge 1 commit into from

Conversation

Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Jan 16, 2025 •
edited
Loading

Summary

  • Adjusts to use ZonedDateTime initially (since we know the timezone information)
  • Converts based on requested TimeZone
  • Added a few extra tests

Closes #2089

Checklist

Delete items not relevant to your PR:

  • Closes #
  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@Paultagoras Paultagoras self-assigned this Jan 16, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
68.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Paultagoras Paultagoras deleted the Date-time-conversion branch January 20, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzitnik mzitnik Awaiting requested review from mzitnik

@chernser chernser Awaiting requested review from chernser

Assignees

@Paultagoras Paultagoras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[jdbc-v2] date/dateTime tests fail when client timezone not UTC/GMT
1 participant
@Paultagoras