Revert "Add FixedString to PostgreSQL mapping" #3670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Revert #3489 due to ClickHouse/ClickHouse#79108
PostgreSQL's CHARACTER type stores number of characters, while ClickHouse's FixedString stores number of bytes. Thus, that 1:1 mapping doesn't work for all encodings. That's the reason it wasn't done for MySQL. Since those types mean different things, I think it's rather misleading to map one to the other. The safest option is to map CHARACTER types that mean characters to String instead.
e.g. there might be a Japanese word of 4 characters but that uses 18 bytes
Checklist