MultiAccordion: Add background color #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Super! Thanks @natalyjazzviolin ! |
danielclickh
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR improves accessibility by increasing the contrast between the multiAccordion background and its parent container in dark mode.
- Introduces a new background color property for the AccordionItem in dark mode.
- Maintains existing styling for light mode.
ariser
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #558
Why
There is not enough contrast between the parent background color and multiAccordion background color:
What
This sets a default color for the multiAccordion to allow for better contrast in dark mode:
Light mode remains unchanged.