Skip to content

MultiAccordion: Add background color #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

natalyjazzviolin
Copy link
Contributor

Closes #558

Why

There is not enough contrast between the parent background color and multiAccordion background color:
Screenshot 2025-03-13 at 12 11 54 PM

What

This sets a default color for the multiAccordion to allow for better contrast in dark mode:
Screenshot 2025-03-13 at 12 13 26 PM

Light mode remains unchanged.

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:28pm

@danielclickh
Copy link

Super! Thanks @natalyjazzviolin !

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves accessibility by increasing the contrast between the multiAccordion background and its parent container in dark mode.

  • Introduces a new background color property for the AccordionItem in dark mode.
  • Maintains existing styling for light mode.

@natalyjazzviolin natalyjazzviolin merged commit e79fab1 into main May 9, 2025
6 checks passed
@natalyjazzviolin natalyjazzviolin deleted the nataly/update-accordion-background-default branch May 9, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add background default
3 participants