Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch: should have cursor:pointer #557

Merged
merged 4 commits into from
Mar 10, 2025
Merged

Switch: should have cursor:pointer #557

merged 4 commits into from
Mar 10, 2025

Conversation

rndD
Copy link
Contributor

@rndD rndD commented Feb 28, 2025

fix #508

Pointer added for not disabled label and switch itself

@rndD rndD requested review from vineethasok and ariser February 28, 2025 16:00
Copy link

vercel bot commented Mar 10, 2025

You must have Developer access to commit code to ClickHouse on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

@rndD
Copy link
Contributor Author

rndD commented Mar 10, 2025

@vineethasok let me know if something is still missing

Copy link
Collaborator

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait on Vineeth in case he has any issues.

Also, would you mind posting a screenshot of this change to the PR, just for posterity and ease?

@vineethasok
Copy link
Collaborator

@rndD I still think it should be inside the genericLabel component and not just in the switch one

@rndD
Copy link
Contributor Author

rndD commented Mar 10, 2025

@vineethasok moved to <GenericLabel>

@rndD rndD merged commit 5803ef5 into main Mar 10, 2025
4 of 5 checks passed
@rndD rndD deleted the switch-fixes branch March 10, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch component should have cursor:pointer
5 participants