-
Notifications
You must be signed in to change notification settings - Fork 262
Extend FFTBasedPoissonSolver to work on AMDGPU #4593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
navidcy
wants to merge
16
commits into
main
Choose a base branch
from
ncc/amdgpu-fft
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+105
−23
Open
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
009bff7
extend plan transforms for Flat
navidcy 8e2621b
add methods for plan_fwd/bwd_transform
661887f
add tests for NonhydrostaticModel
navidcy 0c97835
compactify tests
navidcy 30eec3a
reorder
navidcy 495be48
test few grids
navidcy f06ae9b
merge main
navidcy 2f54d0e
merge main
navidcy f835c0d
Add tests for AMDGPU with HydrostaticFreeSurfaceModel
glwagner 039bcce
Merge branch 'main' into ncc/amdgpu-fft
glwagner f9a2daa
Merge branch 'main' into ncc/amdgpu-fft
giordano b07b3c0
[AMDGPUExt] Use FFT functions from `AbstractFFTs` instead non-existin…
giordano de4e9e9
Update test/test_amdgpu.jl
glwagner fa511bf
Add compat bound for `AbstractFFTs`
giordano 6df3882
Merge branch 'main' into ncc/amdgpu-fft
giordano f3da27f
Remove trailing blank line
giordano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the
plan_bfft!, not theplan_ifft!do we need to add a normalisation or something?