Skip to content

Conversation

@navidcy
Copy link
Member

@navidcy navidcy commented Mar 13, 2025

This PR exposes the pickup functionality from run! (so we can add new methods for picking up a coupled ocean-sea ice simulation in ClimaOcean).

related to CliMA/ClimaOcean.jl#401

@navidcy navidcy requested a review from glwagner March 13, 2025 06:24
@navidcy
Copy link
Member Author

navidcy commented Mar 13, 2025

Tricky was to remove the ::AbstractModel type from set!(model::AbstractModel, filepath::AbstractString). Otherwise I wasn't able to extend set! in ClimaOcean.

@navidcy
Copy link
Member Author

navidcy commented Mar 13, 2025

Actually, with CliMA/ClimaOcean.jl@9ab0df1 we don't seem to be needing this PR at all!

@taimoorsohail
Copy link
Collaborator

Shall we close this PR?

@navidcy navidcy closed this Mar 14, 2025
@navidcy
Copy link
Member Author

navidcy commented Mar 14, 2025

(we can reopen if needed)

@giordano giordano deleted the ts-ncc/expose-pickup branch April 5, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants