-
Notifications
You must be signed in to change notification settings - Fork 3
feat: p3 simulation with liquid-ice collisions #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
haakon-e
wants to merge
1
commit into
main
Choose a base branch
from
he/feat-p3-ice-precipitation-scheme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Jul 25, 2025
ef4a1d7 to
5892069
Compare
97c46c9 to
5326a49
Compare
5892069 to
278249b
Compare
5326a49 to
61cc1a2
Compare
278249b to
c230ef0
Compare
61cc1a2 to
2a86ba3
Compare
c230ef0 to
8f0edfb
Compare
2a86ba3 to
2551f64
Compare
1 task
8f0edfb to
190a998
Compare
2551f64 to
723a369
Compare
190a998 to
9bf2535
Compare
723a369 to
ed75064
Compare
9bf2535 to
4e7d411
Compare
ed75064 to
534b2c0
Compare
4e7d411 to
30d9141
Compare
534b2c0 to
7bfbc57
Compare
30d9141 to
8239464
Compare
7bfbc57 to
b5a16a6
Compare
8239464 to
2f5f844
Compare
b5a16a6 to
e164fbb
Compare
This was referenced Aug 16, 2025
4a69df7 to
944d99e
Compare
e164fbb to
9594689
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## he/rft-improve-error-handling #229 +/- ##
=================================================================
- Coverage 67.93% 63.85% -4.09%
=================================================================
Files 19 19
Lines 1310 1397 +87
=================================================================
+ Hits 890 892 +2
- Misses 420 505 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
be81faf to
58312c4
Compare
58312c4 to
ba8555a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new combined precipitation scheme,
Precipitation2M_P3, which integrates a two-moment rain scheme with a P3-based ice precipitation scheme. The changes include new type definitions, updates to initialization and auxiliary computation functions, and the implementation of collision and advection tendencies for the new scheme. This enables more physically detailed modeling of mixed-phase precipitation processes.New Precipitation Scheme Implementation
IcePrecipitationP3andPrecipitation2M_P3to represent the P3 ice scheme and the combined two-moment rain + P3 ice scheme, respectively, and exported them inequation_types.jl. [1] [2]Initialization and State Handling
helper_functions.jl,initial_condition.jl, andode_utils.jlto handle state variables and auxiliary variables required byPrecipitation2M_P3andIcePrecipitationP3. This includes new fields for riming and distribution parameters. [1] [2] [3] [4] [5]Auxiliary Computations
precompute_aux_thermo!,precompute_aux_precip!, and related functions for the new precipitation types, ensuring derived quantities and terminal velocities are calculated for both rain and ice components. [1] [2]Source Terms and Tendencies
precip_sources_tendency!), including bulk liquid-ice collision logic and updates to all relevant state variables.IcePrecipitationP3andPrecipitation2M_P3, handling the transport of ice-related quantities.Integration and Output
These changes collectively enable detailed simulation of mixed-phase precipitation processes, combining established rain and advanced ice microphysics.