Skip to content

Conversation

@xkykai
Copy link
Collaborator

@xkykai xkykai commented Oct 11, 2025

This PR aims to develop a half-degree global simulation with GM closure

@glwagner
Copy link
Member

Should we replace the one-degree example with this one?

5. Possibly, additional "bulk" properties of the surface media and radiation fluxes
in order to compute an equilibrium "skin" surface temperature that differs from the
bulk temperature below the surface.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was all of this deleted?

z_faces = ExponentialDiscretization(Nz, -6000, 0; scale=1800)

const z_surf = z_faces.cᵃᵃᶠ(Nz)
const z_surf = z_faces(Nz)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why const?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess because it's used in a function later?

@inline mask(x, y, z, t) = z ≥ z_surf - 1

Comment on lines 4 to 12
using Oceananigans.Grids
using Oceananigans.Units
using Oceananigans.OrthogonalSphericalShellGrids
using Oceananigans.BuoyancyFormulations: buoyancy, buoyancy_frequency
using ClimaOcean.OceanSimulations
using ClimaOcean.ECCO
using ClimaOcean.JRA55
using ClimaOcean.DataWrangling
using ClimaSeaIce.SeaIceThermodynamics: IceWaterThermalEquilibrium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
using Oceananigans.Grids
using Oceananigans.Units
using Oceananigans.OrthogonalSphericalShellGrids
using Oceananigans.BuoyancyFormulations: buoyancy, buoyancy_frequency
using ClimaOcean.OceanSimulations
using ClimaOcean.ECCO
using ClimaOcean.JRA55
using ClimaOcean.DataWrangling
using ClimaSeaIce.SeaIceThermodynamics: IceWaterThermalEquilibrium
using Oceananigans.Units

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants