-
Notifications
You must be signed in to change notification settings - Fork 21
Add the possibility to use the Veros ocean model as the ocean component in ClimaOcean #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/OceanSeaIceModels/InterfaceComputations/assemble_net_fluxes.jl
Outdated
Show resolved
Hide resolved
src/OceanSeaIceModels/InterfaceComputations/assemble_net_fluxes.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
I think this is ready on the ClimaOcean side of things, I'm not sure whether to add tests or not since it might create issues with CI. ClimaOcean.jl/ext/ClimaOceanPythonCallExt/veros_state_exchanger.jl Lines 86 to 115 in ac8d821
which we are sorting out on the veros side today. |
I think this is ready to merge. We probably have to tweak the extension again after https://github.com/nutrik/veros/tree/atm_coupling is merged into main, and we have space where to fill in salt and temperature flux. |
This is an exploratory PR to use ClimaOcean to force a veros setup.
This exercise is also usefull to make sure that ClimaOcean does not necessarily assume that the ocean model comes from Oceananigans but it is flexible enough to handle different ocean configurations.